Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thunderbird, thunderbird-bin: 68.4.2 -> 68.5.0 [High security fixes] #79917

Merged
merged 2 commits into from Feb 13, 2020
Merged

thunderbird, thunderbird-bin: 68.4.2 -> 68.5.0 [High security fixes] #79917

merged 2 commits into from Feb 13, 2020

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Feb 12, 2020

Motivation for this change
  • High security fixes
  • Other improvements and fixes.

https://www.thunderbird.net/en-US/thunderbird/68.5.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-07/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@taku0 taku0 mentioned this pull request Feb 12, 2020
Closed
10 tasks
@taku0
Copy link
Contributor Author

taku0 commented Feb 12, 2020

For release-19.09: #79918

vcunat
vcunat approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both seem to run fine for me.

On current master some dependencies of thunderbird need #79930 to build.

lovesegfault
lovesegfault approved these changes Feb 12, 2020
View reviewed changes
Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works :)

@flokli
Copy link
Contributor

flokli commented Feb 12, 2020

Thanks! For these fixes, please also file PRs, or ping @NixOS/backports so this will land in 20.03 as well.

vcunat added a commit that referenced this pull request Feb 13, 2020
@vcunat
Merge #79917: thunderbird*: 68.4.2 -> 68.5.0 (security)
705a131
@vcunat vcunat merged commit 64fe2b7 into NixOS:master Feb 13, 2020
@vcunat
Copy link
Member

vcunat commented Feb 13, 2020

Re-tested for 20.03 as well and pushed as 7e10d60 and 0ce2f49.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@lovesegfault lovesegfault lovesegfault approved these changes

@nbp nbp Awaiting requested review from nbp

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@taku0 @flokli @vcunat @lovesegfault @veprbl