Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cargo-udeps: 0.1.5 -> 0.1.7 #79785

Merged
merged 1 commit into from Feb 13, 2020
Merged

cargo-udeps: 0.1.5 -> 0.1.7 #79785

merged 1 commit into from Feb 13, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

I need the newer version since it adds support for Cargo.lock v2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

B4dM4n
B4dM4n approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@B4dM4n B4dM4n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

The binary is working fine on Linux.

@lovesegfault
Copy link
Member Author

cc. @worldofpeace @andir for merging

@worldofpeace worldofpeace merged commit 0a33a4a into NixOS:master Feb 13, 2020
@worldofpeace
Copy link
Contributor

Thanks @lovesegfault ✨

@lovesegfault lovesegfault deleted the cargo-udeps-0.1.7 branch April 7, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@B4dM4n B4dM4n B4dM4n approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovesegfault @worldofpeace @B4dM4n