Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/filesystems: don't chown /run/keys recursively #79862

Merged
merged 1 commit into from Feb 12, 2020
Merged

nixos/filesystems: don't chown /run/keys recursively #79862

merged 1 commit into from Feb 12, 2020

Conversation

flokli
Copy link
Contributor

@flokli flokli commented Feb 11, 2020 •
edited

Motivation for this change

3c74e48 was a bit too much, it updated
permissions of all files recursively, causing files to be readable by
the group.

This isn't a problem immediately after bootup, but on a new activation,
as tmpfiles.d get restarted then, updating the permission bits of
now-existing files.

This updates the Z to be a z (the non-recursive variant), and adds a
d to ensure a directory is created (which should be covered by the
initrd shell script anyway)

cc @NixOS/backports

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@flokli
nixos/filesystems: don't chown /run/keys recursively
4c8bdd1 
3c74e48 was a bit too much, it updated
permissions of all files recursively, causing files to be readable by
the group.

This isn't a problem immediately after bootup, but on a new activation,
as tmpfiles.d get restarted then, updating the permission bits of
now-existing files.

This updates the `Z` to be a `z` (the non-recursive variant), and adds a
`d` to ensure a directory is created (which should be covered by the
initrd shell script anyway)
@flokli flokli added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 11, 2020
@flokli flokli added this to the 20.03 milestone Feb 11, 2020
aanderse
aanderse approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@aanderse aanderse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is much better idea 👍
Thanks @flokli!

@flokli flokli merged commit b2c2eae into NixOS:master Feb 12, 2020
@flokli
Copy link
Contributor Author

flokli commented Feb 12, 2020

Backported to 20.03 in 9fafbd1.

@flokli flokli deleted the fix-run-keys branch February 12, 2020 16:53
@flokli flokli mentioned this pull request Feb 12, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse aanderse approved these changes

@Mic92 Mic92 Awaiting requested review from Mic92

@fpletz fpletz Awaiting requested review from fpletz

@lheckemann lheckemann Awaiting requested review from lheckemann

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
20.03
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@flokli @aanderse