Fix 805ecd32be64e14d8555ebc06eadf673bdf401ee: Incorrect length specifier #7995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was already fixed in trunk by #7994 . It will be backported to the release branch before the next release |
|
Also, please avoid using the full 40char commit hash in commit messages - don't rely on GH to shorten it for you! |
|
I thought relying on short hashes was a bad idea? |
|
Depends. With 3-4 characters you're going to run into problems. 7-10 you'll have no problems at all ever. Even the Linux kernel only needs 8 to uniquely identify every single one of its commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
g++ (Debian 8.3.0-6) 8.3.0complains:In 805ecd3, variable type got changed, but not the
printflength specifier.