Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(20.03) trezord-go: 2.0.27 -> 2.0.28 #79903

Merged
merged 1 commit into from Feb 13, 2020
Merged

(20.03) trezord-go: 2.0.27 -> 2.0.28 #79903

merged 1 commit into from Feb 13, 2020

Conversation

mmahut
Copy link
Member

@mmahut mmahut commented Feb 12, 2020

Motivation for this change

2.0.28 contains an important fix yet is a small release, I would like to propose it for a backport.

(cherry picked from commit ab1a14d, PR #79857)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mmahut
trezord-go: 2.0.27 -> 2.0.28
9690c7e 
(cherry picked from commit ab1a14d)
@mmahut
Copy link
Member Author

mmahut commented Feb 12, 2020

@GrahamcOfBorg test trezord

@ofborg ofborg bot requested review from ehmry, 1000101, jb55 and prusnak February 12, 2020 08:06
@mmahut mmahut added the 8.has: port to stable A PR already has a backport to the stable release. label Feb 12, 2020
@mmahut mmahut merged commit 7e4eea6 into NixOS:release-20.03 Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ehmry ehmry Awaiting requested review from ehmry

@1000101 1000101 Awaiting requested review from 1000101

@jb55 jb55 Awaiting requested review from jb55

@prusnak prusnak Awaiting requested review from prusnak

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mmahut