[WPT/common/security-features] Add SharedWorkers as source contexts #21732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 11, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2048118
branch
from
2fb826f
to
11ad5e1
Compare
This CL adds support for
{classic|module} {http(s):|data:} SharedWorkerGlobalScope
as source contexts, namely:
"sharedworker-classic", "sharedworker-module",
"sharedworker-classic-data", "sharedworker-module-data"
Actual tests for such cases will be added by subsequent CLs.
Bug: 1048619, 881202, 906850
Change-Id: I72c71c303430014a68cecfa65a08dcaf9a23b6c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048118
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740877}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2048118
branch
from
11ad5e1
to
b7d1289
Compare
|
@Hexcles timeout on Firefox and Chrome. Would you mind taking a look and see if its safe to admin merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds support for
{classic|module} {http(s):|data:} SharedWorkerGlobalScope
as source contexts, namely:
"sharedworker-classic", "sharedworker-module",
"sharedworker-classic-data", "sharedworker-module-data"
Actual tests for such cases will be added by subsequent CLs.
Bug: 1048619, 881202, 906850
Change-Id: I72c71c303430014a68cecfa65a08dcaf9a23b6c9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2048118
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Reviewed-by: Kenichi Ishibashi <bashi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740877}