Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdesktop: 1.9.9 -> 1.9.12 #79867

Merged
merged 2 commits into from Feb 12, 2020
Merged

tdesktop: 1.9.9 -> 1.9.12 #79867

merged 2 commits into from Feb 12, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Feb 11, 2020 •
edited

Status

Didn't test the executable yet (can do that tomorrow), but at least the build works. Ran fine so far.

Motivation for this change

cc @ilya-fedin FYI and it probably makes sense to collaborate on this update due to the two new dependencies (if we plan to package them in Nixpkgs).
I'm a bit low on time and didn't have time to package mapbox-variant (GH) if you want to try packaging it (but I suspect I'll be annoying to get it packaged as it uses a Makefile and some custom hacks that don't make sense for Nixpkgs/packaging) for kotatogram-desktop I can wait with this PR.
Update: Most likely there won't be a kotatogram-desktop release very soon.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
tl-expected: init at 2019-11-11
818628c 
This version is 5 commits ahead of version 1.0.0 because we need at
least one patch [0] that prevents CMake from trying to use Git to fetch
the already fetched submodule...
Also some files have the wrong formatting (CRLF line endings) which
makes the patching really messy. At this point is seems therefore better
to use the master version instead (1.0.0 is pretty broken regarding
CMake).

[0]: TartanLlama/expected@0ca73ee
@primeos
tdesktop: 1.9.9 -> 1.9.12
d0729f8 
Note: I skipped the packaging of mapbox-variant for now.
@primeos primeos marked this pull request as ready for review February 11, 2020 23:59
@ofborg ofborg bot requested a review from abbradar February 12, 2020 00:18
@primeos primeos merged commit fc3f421 into NixOS:master Feb 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos