Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[backport-19.09]: nixos/locate: only create output directory if != /var/cache #79820

Merged
merged 1 commit into from Feb 11, 2020
Merged

[backport-19.09]: nixos/locate: only create output directory if != /var/cache #79820

merged 1 commit into from Feb 11, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Feb 11, 2020 •
edited

We already create /var/cache as part of systemd default rules.

Continuation of:
c9d6dee

Reported in:
#79022 (comment)

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92
nixos/locate: only create output directory if != /var/cache
8e8ad80 
We already create /var/cache as part of systemd default rules.

Continuation of:
NixOS@c9d6dee

Reported in:
NixOS#79022 (comment)
@Mic92 Mic92 mentioned this pull request Feb 11, 2020
Merged
10 tasks
@worldofpeace worldofpeace changed the base branch from nixos-19.09 to release-19.09 February 11, 2020 12:54
@worldofpeace
Copy link
Contributor

We need this for 20.03 as well I guess.

@Mic92
Copy link
Member Author

Mic92 commented Feb 11, 2020

This should be fixed in 20.03 already with #79022

@Mic92 Mic92 merged commit 1694601 into NixOS:release-19.09 Feb 11, 2020
@Mic92 Mic92 deleted the locate branch February 11, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Mic92 @worldofpeace