Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vulkan: 1.1 -> 1.2 (backport to 20.03) #79852

Merged
merged 6 commits into from Feb 18, 2020
Merged

vulkan: 1.1 -> 1.2 (backport to 20.03) #79852

merged 6 commits into from Feb 18, 2020

Conversation

Ralith
Copy link
Contributor

@Ralith Ralith commented Feb 11, 2020

Motivation for this change

Backport of #78746 so current Vulkan apps can be built on 20.03.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ralith Ralith mentioned this pull request Feb 11, 2020
Merged
10 tasks
@Ralith
Copy link
Contributor Author

Ralith commented Feb 17, 2020

bump @FRidh

@FRidh
Copy link
Member

FRidh commented Feb 18, 2020

Please always use cherry-pick -x when backporting.

@Ralith
Copy link
Contributor Author

Ralith commented Feb 18, 2020

Done.

@FRidh FRidh merged commit 07f97d3 into NixOS:release-20.03 Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Ralith @FRidh