Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fscrypt-experimental: 0.2.5 -> 0.2.6 #79853

Merged
merged 1 commit into from Feb 12, 2020
Merged

fscrypt-experimental: 0.2.5 -> 0.2.6 #79853

merged 1 commit into from Feb 12, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Feb 11, 2020 •
edited

Motivation for this change

Unfortunately this requires some hacks atm, but the result should be fine.
Update: Ran a few tests and it seems fine so far :)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from kalbasit February 11, 2020 19:26
@primeos primeos merged commit ac758ca into NixOS:master Feb 12, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Feb 13, 2020
@primeos @dtzWill
fscrypt-experimental: 0.2.5 -> 0.2.6 (NixOS#79853)
f0db503 
Changelog: https://github.com/google/fscrypt/releases/tag/v0.2.6
(cherry picked from commit ac758ca)
primeos added a commit that referenced this pull request Feb 15, 2020
@primeos
fscrypt-experimental: 0.2.5 -> 0.2.6 (#79853)
25955ae 
Changelog: https://github.com/google/fscrypt/releases/tag/v0.2.6
(cherry picked from commit ac758ca)
Reason: Since NixOS 20.03 will ship with Linux kernel 5.4 by default,
the new support for v2 kernel encryption policies is useful.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@primeos