Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

source-han-{sans,serif,mono}: {update,refactor,init} #79776

Merged
merged 1 commit into from Feb 29, 2020
Merged

source-han-{sans,serif,mono}: {update,refactor,init} #79776

merged 1 commit into from Feb 29, 2020

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented Feb 10, 2020

Motivation for this change

The Source Han fonts now use shared package infrastructure, and the Super OTC distributions, which unify the various scripts into a single bundle file, improving automatic font selection and reducing overall disk space usage. This also means that the Traditional Chinese—Hong Kong language variant is now included.

The old package names including language are aliased to the Super OTC bundle packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@emilazy
Copy link
Member Author

emilazy commented Feb 10, 2020

@GrahamcOfBorg build source-han-sans source-han-serif source-han-mono

@ofborg ofborg bot requested a review from taku0 February 11, 2020 00:43
@taku0
Copy link
Contributor

taku0 commented Feb 11, 2020

The official README recommends language specific OTFs for Linux. Actually, I experienced that some applications (sorry, I forgot which one was) fail to select proper language. I will try this branch.

@emilazy
Copy link
Member Author

emilazy commented Feb 11, 2020

I don't see any specific recommendation for Linux in that document (but maybe I'm missing it?), just notes that lots of font engines don't handle the Super OTCs well – I think that's probably out of date, since I've had no problems with it in my testing so far, and if anything the results for multilingual content are better. Custom fontconfig does potentially need adjusting to use the generic Source Han … aliases without the language code, though. This upstream issue for Noto CJK (which is almost identical to Source Han) suggests that Super OTCs would be recommended for Linux if there were any concrete recommendations.

@taku0
Copy link
Contributor

taku0 commented Feb 11, 2020

I mean “Other” in the flowchart. Anyway, I will try this branch with Firefox, Inkscape, LibreOffice, KDE, and GNOME desktop in a clean virtual machine.

taku0
taku0 approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works fine, at least for Japanese locale. Size of the files could be a problem, but IMO it is acceptable.

@emilazy
Copy link
Member Author

emilazy commented Feb 11, 2020

Updated to use stdenvNoCC to cut down on extraneous rebuilds.

@GrahamcOfBorg build source-han-sans source-han-serif source-han-mono

@ofborg ofborg bot requested a review from taku0 February 11, 2020 21:03
taku0
taku0 approved these changes Feb 15, 2020
View reviewed changes
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emilazy @lukateras
source-han-{sans,serif,mono}: {update,refactor,init}
6eb45bf 
* source-han-sans: 1.004R -> 2.001
* source-han-serif: switch to Super OTC
* source-han-mono: init at 1.002

The Source Han fonts now use shared package infrastructure, and the
Super OTC distributions, which unify the various scripts into a single
bundle file, improving automatic font selection and reducing overall
disk space usage. This also means that the Traditional
Chinese—Hong Kong language variant is now included.

The old package names including language are aliased to the Super OTC
bundle packages.
@ofborg ofborg bot requested a review from taku0 February 29, 2020 12:03
@lukateras lukateras merged commit 6602e9a into NixOS:master Feb 29, 2020
taku0
taku0 approved these changes Feb 29, 2020
View reviewed changes
Copy link
Contributor

@taku0 taku0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Only the context of the diffs are changed.
0715ba3
6eb45bf

@emilazy emilazy deleted the update-source-han-fonts branch February 29, 2020 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taku0 taku0 taku0 approved these changes

@lukateras lukateras lukateras approved these changes

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emilazy @taku0 @lukateras