Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

delly: 0.8.1 -> 0.8.2 #79778

Merged
merged 1 commit into from Feb 11, 2020
Merged

delly: 0.8.1 -> 0.8.2 #79778

merged 1 commit into from Feb 11, 2020

Conversation

jbedo
Copy link
Contributor

@jbedo jbedo commented Feb 10, 2020

Bumped version and backported patch to fix building with htslib 1.10.2.

Motivation for this change

Previous expression was broken by 940d12b

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@scalavision

@jbedo
delly: 0.8.1 -> 0.8.2
a8fe9e7 
Backported patch required for htslib 1.10.2
veprbl
veprbl approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes the build, executable runs

@veprbl veprbl merged commit 5f2a3be into NixOS:master Feb 11, 2020
@veprbl
Copy link
Member

veprbl commented Feb 11, 2020

Ported to 20.03 in 1781000

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

@markuskowa markuskowa Awaiting requested review from markuskowa

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jbedo @veprbl