Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pysaml2: fix tests #79779

Merged
merged 1 commit into from Feb 11, 2020
Merged

pythonPackages.pysaml2: fix tests #79779

merged 1 commit into from Feb 11, 2020

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Feb 10, 2020

Motivation for this change

A couple of tests used fixed timestamps that only expired (and upstream only seem to have noticed) today: IdentityPython/pysaml2@1d97d2d

Already updated for release-19.09 in #79773

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle force-pushed the ris-pysaml2-fix-fixed-date-tests branch from d7024f6 to 1b9c7b8 Compare February 11, 2020 20:52
@risicle
pythonPackages.pysaml2: fix tests with fixed & now-expired timestamps
65aff78 
these only expired (and upstream only seem to have noticed) today
@risicle risicle force-pushed the ris-pysaml2-fix-fixed-date-tests branch from 1b9c7b8 to 65aff78 Compare February 11, 2020 20:53
jonringer
jonringer approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/79779
3 package built:
matrix-synapse python37Packages.pysaml2 python38Packages.pysaml2

@jonringer jonringer merged commit f77e057 into NixOS:master Feb 11, 2020
@Ma27
Copy link
Member

Ma27 commented Feb 17, 2020

Backported as 194c1ea to fix the build on 20.03.

@Ma27 Ma27 added the 8.has: port to stable A PR already has a backport to the stable release. label Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @Ma27 @jonringer