New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cinnamon.xapps: move gobject-introspection to buildInputs #79780
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the bindings are generated using g-ir-*
tools, this needs to be in nativeBuildInputs
. If this project also links against libgirepository-1.0.so
or depends on one of the typelibs shipped along, then it should go to buildInputs
as well.
Could you mention the reason in the commit message?
Also the message is confusing, as gobject (GLib’s object system) ≠ gobject-introspection (set of tooling for introspecting libraries based on GObject and generating bindable typelib libraries from the introspected data). To add to the confusion, gobject-introspection
package also does provide typelibs for glib (including GObject-2.0.typelib
).
I have no idea. It seems to reference glib-object.h in some places, but otherwise I just followed the pattern of @worldofpeace telling me that I should add |
These are the typelibs it needs to generate girs https://github.com/linuxmint/xapps/blob/31133349e33260659e76c83f6edae57c38b0dc2b/libxapp/meson.build#L106 |
So build input or not? |
I believe it falls under the "generating bindable typelib libraries from the introspected data" so it should be native. But we can confirm this with @jtojnar. |
Well, that would be for the generator but typelibs itself are runtime dependencies so they should go to regular |
😄 Ahh, we should probably document this to help people out. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix your commit message?
Thank you @mkg20001. |
Perhaps I should have been clearer, it should still be in |
The distinction between The build-time platform uses dependencies |
This makes sense Is this in the docs somewhere? Could be added if not under the gnome packaging section. |
It is described in https://nixos.org/nixpkgs/manual/#chap-cross and rather hard to digest https://nixos.org/nixpkgs/manual/#ssec-stdenv-dependencies (see #57595 for rendered diagrams). |
Ohhh, strictDeps would have made this obvious. |
Not entirely academic – lot of people are cross-compiling stuff. Though to be fair |
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)