Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gunicorn: add 19.x branch for python2.7 support #79782

Merged
merged 1 commit into from Feb 11, 2020
Merged

gunicorn: add 19.x branch for python2.7 support #79782

merged 1 commit into from Feb 11, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Feb 10, 2020

The nixos/moinmoin module uses gunicorn, however the 20.0 version dropped python2 support which broke the module as there's no python3 port planned for moinmoin: http://moinmo.in/Python3

Motivation for this change

nix-build nixos/tests/moinmoin.nix fails

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @FRidh @jonringer

@mmilata
gunicorn: add 19.x branch for python2.7 support
d202e9e 
The nixos/moinmoin module uses gunicorn, however the 20.0 version
dropped python2 support which broke the module as there's no python3
port planned for moinmoin: http://moinmo.in/Python3
jonringer
jonringer approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

https://github.com/NixOS/nixpkgs/pull/79782
5 package built:
python27Packages.flask-sockets python27Packages.gevent-socketio python27Packages.gevent-websocket python27Packages.gunicorn python27Packages.runway-python

@jonringer
Copy link
Contributor

the commit msg should be something similar to:

python2Packages.gunicorn: freeze at 19.10.0

but I should have caught that in my previous review

@jonringer jonringer merged commit b86f4d5 into NixOS:master Feb 11, 2020
@mmilata
Copy link
Member Author

mmilata commented Feb 11, 2020

@jonringer thanks! Will keep that in mind next time.

@mmilata mmilata deleted the gunicorn-python27 branch February 11, 2020 03:28
@jonringer jonringer mentioned this pull request Feb 11, 2020
Merged
10 tasks
@mmilata mmilata mentioned this pull request Feb 11, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mmilata @jonringer