Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rngd: Start early during boot and encrypted swap entropy fix [20.03] #79833

Merged
merged 2 commits into from Feb 11, 2020
Merged

rngd: Start early during boot and encrypted swap entropy fix [20.03] #79833

merged 2 commits into from Feb 11, 2020

Conversation

tokudan
Copy link
Contributor

@tokudan tokudan commented Feb 11, 2020

Motivation for this change

#71302 hasn't been merged in time before the split off, but entropy starvation during boot is pretty annoying, so this is a backport of the commits.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tokudan
swap: depend on rngd if enabled and randomEncryption is configured to
93bd12d 
avoid entropy starvation during boot

(cherry picked from commit 1ac86e1)
@tokudan
security.rngd: start rngd during early boot to reduce entropy starvat…
4579f11 
…ion due to encrypted swap and remove PrivateTmp to avoid a circular dependency

(cherry picked from commit d14ba1e)
@tokudan
Copy link
Contributor Author

tokudan commented Feb 11, 2020

@GrahamcOfBorg test installer

@rnhmjoj rnhmjoj merged commit d3d8d5c into NixOS:release-20.03 Feb 11, 2020
@rnhmjoj
Copy link
Contributor

rnhmjoj commented Feb 11, 2020

Thank you.

@worldofpeace worldofpeace mentioned this pull request Feb 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tokudan @rnhmjoj