nixos/display-managers: Add DesktopNames parameter to generated desktop session files #79830
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually forgot to request this when I reviewed the PR that added it. |
|
@ilya-fedin your commit message don't match the contributing guidelines https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#submitting-changes. It should be prefixed with the package name or module path. |
10 tasks
|
Good catch. We should probably also check whether the downstream session names match the upstream ones. |
…op session files Some display managers (e.g. SDDM) set the XDG_CURRENT_DESKTOP variable accroding to this parameter. If this variable is not defined, there will be some problems (e.g. MATE doesn't have icons on the desktop). Fixes NixOS#71427
ilya-fedin
force-pushed
the
fix-xdg-current-desktop
branch
from
04266c8
to
f7768c9
Compare
|
@worldofpeace oops, thanks |
jtojnar
approved these changes
Feb 12, 2020
worldofpeace
changed the title
|
@ilya-fedin Can you open a backport of this to release-20.03 https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md#backporting-changes? |
10 tasks
Okay |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Some display managers (e.g. SDDM) set the XDG_CURRENT_DESKTOP variable accroding to this parameter.
If this variable is not defined, there will be some problems (e.g. MATE doesn't have icons on the desktop).
Fixes #71427
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)