Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate AppIndicator support in onboard #79831

Closed
wants to merge 1 commit into from

Conversation

ilya-fedin
Copy link
Contributor

@ilya-fedin ilya-fedin commented Feb 11, 2020

Motivation for this change

For HiDPI and Wayland-friendly tray icon

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@worldofpeace
Copy link
Contributor

I'd really not like this deprecated library in onboard which we still use in Pantheon.

@johnramsden
Copy link
Member

This is just for HiDPi icons? I don't see anything wrong with this PR, but I do see that the package appears to be depreciated in Debian. @worldofpeace is that your concern?

For HiDPI and Wayland-friendly tray icon
@ilya-fedin
Copy link
Contributor Author

ilya-fedin commented Feb 12, 2020

I'd really not like this deprecated library in onboard which we still use in Pantheon.

libayatana-appindicator can be an option

@johnramsden
Copy link
Member

It appears that's what they did in debian. Doesn't look like it's packaged yet though. Seems that's been mentioned as a good option in #54130 , not sure if it never went anywhere.

@jtojnar
Copy link
Contributor

jtojnar commented Feb 12, 2020

Did not get around to packaging the libatayana-appindicator yet. Would love it if someone could do it.

@stale
Copy link

stale bot commented Aug 10, 2020

Hello, I'm a bot and I thank you in the name of the community for your contributions.

Nixpkgs is a busy repository, and unfortunately sometimes PRs get left behind for too long. Nevertheless, we'd like to help committers reach the PRs that are still important. This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

If this is still important to you and you'd like to remove the stale label, we ask that you leave a comment. Your comment can be as simple as "still important to me". But there's a bit more you can do:

If you received an approval by an unprivileged maintainer and you are just waiting for a merge, you can @ mention someone with merge permissions and ask them to help. You might be able to find someone relevant by using Git blame on the relevant files, or via GitHub's web interface. You can see if someone's a member of the nixpkgs-committers team, by hovering with the mouse over their username on the web interface, or by searching them directly on the list.

If your PR wasn't reviewed at all, it might help to find someone who's perhaps a user of the package or module you are changing, or alternatively, ask once more for a review by the maintainer of the package/module this is about. If you don't know any, you can use Git blame on the relevant files, or GitHub's web interface to find someone who touched the relevant files in the past.

If your PR has had reviews and nevertheless got stale, make sure you've responded to all of the reviewer's requests / questions. Usually when PR authors show responsibility and dedication, reviewers (privileged or not) show dedication as well. If you've pushed a change, it's possible the reviewer wasn't notified about your push via email, so you can always officially request them for a review, or just @ mention them and say you've addressed their comments.

Lastly, you can always ask for help at our Discourse Forum, or more specifically, at this thread or at #nixos' IRC channel.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 10, 2020
@ilya-fedin
Copy link
Contributor Author

This PR has had no activity for 180 days, and so I marked it as stale, but you can rest assured it will never be closed by a non-human.

I'm waiting for #79832, there's no sense to work on this if I can't use indicator-application anyway.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 10, 2020
@jtojnar
Copy link
Contributor

jtojnar commented Aug 10, 2020

Atayana libraries were packaged in #88783

@SuperSandro2000
Copy link
Member

@ilya-fedin ping

@ilya-fedin
Copy link
Contributor Author

Well, I don't need this anymore

@ilya-fedin ilya-fedin closed this Jan 18, 2021
@ilya-fedin ilya-fedin deleted the onboard-use-appindicator branch March 15, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants