Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[r19.09] pythonPackages.pysaml2: add patch for CVE-2020-5390 #79773

Closed
wants to merge 2 commits into from
Closed

[r19.09] pythonPackages.pysaml2: add patch for CVE-2020-5390 #79773

wants to merge 2 commits into from

Conversation

risicle
Copy link
Contributor

@risicle risicle commented Feb 10, 2020

Motivation for this change

https://nvd.nist.gov/vuln/detail/CVE-2020-5390

Patching this instead of bumping allows us to keep it enabled for python 2.7 for this release.

See #79662 for master.

Entertainingly, while I was working on this one of the packages tests with fixed timestamps expired and started failing, which was confusing. Fixed by applying IdentityPython/pysaml2@1d97d2d, which it looks like I'll have to apply to master too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@risicle risicle requested a review from FRidh as a code owner February 10, 2020 22:41
@risicle risicle mentioned this pull request Feb 10, 2020
Merged
10 tasks
@doronbehar
Copy link
Contributor

Closing as target branch is too old.

@doronbehar doronbehar closed this Sep 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

Assignees
No one assigned
Labels
1.severity: security 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@risicle @doronbehar @veprbl