Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git: Fix git-gui to work on Catalina #79769

Merged
merged 1 commit into from Feb 19, 2020
Merged

git: Fix git-gui to work on Catalina #79769

merged 1 commit into from Feb 19, 2020

Conversation

virusdave
Copy link
Contributor

@virusdave virusdave commented Feb 10, 2020 •
edited

Motivation for this change

The existing post-install was not successfully patching the git-gui script,
and thus was invoking the packaged osx app which uses the system tk,
which is too old to work (and is no longer supported by Apple anyway).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

git: Fix git-gui to work on Catalina
1b6ef12 
The existing post-install was not successfully patching the git-gui script,
and thus was invoking the packaged osx app which uses the system tk,
which is too old to work (and is no longer supported by Apple anyway).
@virusdave
Copy link
Contributor Author

(Testing locally now. I'll remove this comment once i'm satisfied git-gui is working as expected)

@veprbl veprbl added the 6.topic: darwin Running or building packages on Darwin label Feb 11, 2020
@bjornfor
Copy link
Contributor

(Testing locally now. I'll remove this comment once i'm satisfied git-gui is working as expected)

Still testing?

@virusdave
Copy link
Contributor Author

(Testing locally now. I'll remove this comment once i'm satisfied git-gui is working as expected)

Still testing?

Sorry, got pulled away by personal life emergency. I'll loop back to this tonight.

@LnL7 LnL7 merged commit af1fffa into NixOS:master Feb 19, 2020
@thefloweringash thefloweringash mentioned this pull request Mar 2, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@LnL7 LnL7 LnL7 approved these changes

@globin globin Awaiting requested review from globin

@peti peti Awaiting requested review from peti

@the-kenny the-kenny Awaiting requested review from the-kenny

@wmertens wmertens Awaiting requested review from wmertens

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@virusdave @bjornfor @LnL7 @veprbl