Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: add link to community chat options #79890

Merged
merged 1 commit into from Feb 12, 2020
Merged

readme: add link to community chat options #79890

merged 1 commit into from Feb 12, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 12, 2020 •
edited

Motivation for this change

The badge won't work until an admin (@zimbatm) enables it, but also open to removing the badge if it takes away from the original intent of the other badges.

related issues:
#79787

related discussion:
https://discourse.nixos.org/t/nixos-nixpkgs-nix-discord-for-voice-communication/5845/29

EDIT: just made a link to the wiki which has many other alternatives

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor Author

requested review from members that I could think of that have done other community outreach activities

samueldr
samueldr requested changes Feb 12, 2020
View reviewed changes
Copy link
Member

@samueldr samueldr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would open the door to the already existing established communities for all other services, in addition to the existing unofficial NixOS Discords listed here to want to add themselves to this list.

See this (probably incomplete) list:

@jonringer
Copy link
Contributor Author

This would open the door to the already existing established communities for all other services, in addition to the existing unofficial NixOS Discords listed here to want to add themselves to this list.

Do you mind instead if I link to the the wiki page then? I didn't even know we had a discord until the thought of creating one crossed my mind.

@samueldr
Copy link
Member

Do you mind instead if I link to the the wiki page then? I didn't even know we had a discord until the thought of creating one crossed my mind.

Adding it to the wiki: sure, go ahead, it's there for this purpose.

Adding the wiki link to the Get In Touch page to the README? I have no strong opinion about it either way. Though I think the wording needs to make it obvious these are additional community-led resources.

ryantm
ryantm requested changes Feb 12, 2020
View reviewed changes
Copy link
Member

@ryantm ryantm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The badge seems way too official. I think linking to that wiki page is a good idea.

@jonringer
Copy link
Contributor Author

I just removed the badge, and just added a link to the the wiki

@jonringer jonringer force-pushed the add-discord branch 2 times, most recently from 7ca4180 to 106f7e0 Compare February 12, 2020 06:03
@jonringer jonringer changed the title readme: add discord link readme: add link to community chat options Feb 12, 2020
ryantm
ryantm requested changes Feb 12, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
jtojnar
jtojnar reviewed Feb 12, 2020
View reviewed changes
README.md Outdated Show resolved Hide resolved
worldofpeace
worldofpeace approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it

@worldofpeace worldofpeace merged commit 3cd8935 into NixOS:master Feb 12, 2020
@jonringer jonringer deleted the add-discord branch February 12, 2020 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar left review comments

@ryantm ryantm ryantm requested changes

@samueldr samueldr samueldr requested changes

@worldofpeace worldofpeace worldofpeace approved these changes

@grahamc grahamc Awaiting requested review from grahamc

@zimbatm zimbatm Awaiting requested review from zimbatm

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@edolstra edolstra Awaiting requested review from edolstra

@aanderse aanderse Awaiting requested review from aanderse

@bhipple bhipple Awaiting requested review from bhipple

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jonringer @samueldr @ryantm @jtojnar @worldofpeace