vscode: Added libdbusmenu support #79889
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eadwu
reviewed
Feb 12, 2020
eadwu
approved these changes
Feb 12, 2020
|
@brcha any chance you can fix up the merge conflict so we can get this merged? |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
still nedded to be merged |
stale
bot
removed
the
2.status: stale
|
@SuperSandro2000 Cow can we check where in the file is the merge conflict? |
|
The link you gave gives me 404 |
|
Still WOM. Click on the resolve conflict button at the bottom of the PR to see the merge conflict. |
|
|
|
Then that button only shows if you can commit things I guess. Please rebase it locally. |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
is this required since 0d3136a ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to enable global menus (appmenus, unity menus, dbusmenus, …) for VSCode and VSCodium. It's worth mentioning the issue: #65680
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)As can be seen on the following screenshot, I've built the VSCode package and it now works with DBusMenus as it should. The only thing I did was to add libdbusmenu-gtk3 to dependencies in several places in the file. I've also tried to honor the Darwin target by adding libdbusmenu-gtk3 only where it didn't apply to Darwin, but, since I don't have a Mac to test this change, nor am I overly versed in Nix{,OS,Pkgs,…} ecosystem, I implore you to check that before accepting this push request. I'm guessing libdbusmenu doesn't work in Mac to provide global menus, but perhaps I'm wrong about that.