Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.ydiff: init at 1.1 #79843

Merged
merged 1 commit into from Feb 14, 2020
Merged

pythonPackages.ydiff: init at 1.1 #79843

merged 1 commit into from Feb 14, 2020

Conversation

invokesus
Copy link
Contributor

@invokesus invokesus commented Feb 11, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from limeytexan February 11, 2020 17:02
@invokesus
Copy link
Contributor Author

invokesus commented Feb 14, 2020 •
edited

Amended and force-pushed. 🙂

jonringer
jonringer approved these changes Feb 14, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM
cool tool

[4 built, 1 copied (0.0 MiB), 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79843
3 package built:
python27Packages.ydiff python37Packages.ydiff python38Packages.ydiff

@jonringer jonringer merged commit ce8d1c2 into NixOS:master Feb 14, 2020
@jonringer jonringer mentioned this pull request Feb 14, 2020
Merged
10 tasks
@invokesus invokesus deleted the contrib/ydiff branch September 14, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@limeytexan limeytexan Awaiting requested review from limeytexan

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@invokesus @jonringer @Janik-Haag