OpenBSD: fix endianness detection #7996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I feel like I should be surprised that there's any OBSD powerpc users at all, but equally I feel I should not be surprised... ;) If you can fixup the commit message (we're quite strict about this!), I'll merge it in |
LordAro
added
the
backport requested
As many OSes EOL'd 32-bit powerpc support, people are slowly coming to us :)
It's done! |
planetmaker
approved these changes
Feb 11, 2020
|
Would be nice if you could check if endian detection works correctly for #7270. I think it should be ok as we rely on cmake, but who knows :) |
LordAro
added
backported
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
@rapenne-s reported to me that OpenTTD colors are off on OpenBSD/macppc (32-bit powerpc). I've found out it's because we don't implement endianness reporting like the rest;
__*_ENDIANand__BYTE_ORDERdon't exist out of the box.This PR adds the appropriate code to fix the issue.
(cc @bentley)