Fix/vscode dbusmenu support #79886
Closed
Fix/vscode dbusmenu support #79886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…6926) (NixOS#76951) (cherry picked from commit 2f22e67)
…9906-r19.09 [r19.09] cyrus_sasl: add patch for CVE-2019-19906
(cherry picked from commit 8c42dba)
(cherry picked from commit 0afc845)
(cherry picked from commit af5f1eb)
(cherry picked from commit 727f2e9)
(cherry picked from commit 482b39a)
https://lists.zx2c4.com/pipermail/wireguard/2020-January/004844.html (cherry picked from commit ed72b90)
(cherry picked from commit 787a7f6)
(cherry picked from commit 39cd457) Backport of NixOS#75182
apache-kafka.nix: Add missing quote inside tmpfiles rule
(cherry picked from commit 2d6f1ff)
(cherry picked from commit 754d02d) It's safe: it just installs a new file into otherwise unused output. Tested nixos.tests.gdk-pixbuf.x86_64-linux
Traceback (most recent call last):
File "/nix/store/8qkdlyv2ckrimvi50qvl0anzv66jcp2j-python-swiftclient-3.6.0/bin/.swift-wrapped", line 7, in <module>
from swiftclient.shell import main
File "/nix/store/8qkdlyv2ckrimvi50qvl0anzv66jcp2j-python-swiftclient-3.6.0/lib/python3.7/site-packages/swiftclient/__init__.py", line 20, in <module>
from .client import * # noqa
File "/nix/store/8qkdlyv2ckrimvi50qvl0anzv66jcp2j-python-swiftclient-3.6.0/lib/python3.7/site-packages/swiftclient/client.py", line 33, in <module>
from swiftclient import version as swiftclient_version
File "/nix/store/8qkdlyv2ckrimvi50qvl0anzv66jcp2j-python-swiftclient-3.6.0/lib/python3.7/site-packages/swiftclient/version.py", line 15, in <module>
import pkg_resources
ModuleNotFoundError: No module named 'pkg_resources'
(cherry picked from commit dfd115a)
(cherry picked from commit 3b15451)
(cherry picked from commit 2ad59bd)
[19.09] firefox: 71.0 -> 72.0
(cherry picked from commit 3f0fee7)
(cherry picked from commit 603e3b1)
ofborg
bot
added
6.topic: emacs
6.topic: erlang
6.topic: fetch
6.topic: GNOME
|
I'm guessing the manual needs updating… it makes absolutely no sense making a PR like this, based on an old (stable) tag. |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I wanted to enable global menus (appmenus, unity menus, dbusmenus, …) for VSCode and VSCodium. It's worth mentioning the issue: #65680
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)As can be seen on the following screenshot, I've built the VSCode package and it now works with DBusMenus as it should. The only thing I did was to add libdbusmenu-gtk3 to dependencies in several places in the file. I've also tried to honor the Darwin target by adding libdbusmenu-gtk3 only where it didn't apply to Darwin, but, since I don't have a Mac to test this change, nor am I overly versed in Nix{,OS,Pkgs,…} ecosystem, I implore you to check that before accepting this push request. I'm guessing libdbusmenu doesn't work in Mac to provide global menus, but perhaps I'm wrong about that.
As suggested by the nixpkgs manual I've made a patch for the branch I'm currently using, stable 19.09, tag c49da64. That is a bit strange approach to me, usually patches are made for master, but I don't think there should be too much difference between this patch and the patch to master, when this concrete file is concerned.