Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tdesktop: creates desktop item post install #79888

Closed
wants to merge 1 commit into from
Closed

tdesktop: creates desktop item post install #79888

wants to merge 1 commit into from

Conversation

ldelelis
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from primeos and abbradar February 12, 2020 03:52
jtojnar
jtojnar requested changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am confused why we would need this. Telegram already has a desktop file that is installed.

@ldelelis
Copy link
Member Author

@jtojnar that wasn't the case for me at least. After installing tdesktop via home-manager, my drun launcher wasn't picking up a desktop item for Telegram. I'll investigate if it wasn't a one off issue however (or a configuration issue), and close this PR if it's necessary

@ldelelis
Copy link
Member Author

Update: After installing though nixOS's default configuration, tdesktop's entry file exists and is available to drun launchers... I'll continue debugging this and see what the correct fix is.

@ldelelis ldelelis closed this Feb 13, 2020
@ldelelis ldelelis deleted the tdesktop-desktop-item branch February 13, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar requested changes

@primeos primeos Awaiting requested review from primeos

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ldelelis @jtojnar