SharedWorker: Give unique names to each shared workers in shared-worker-options-type.html #21748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Feb 12, 2020
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2050051
branch
2 times, most recently
from
0456a2b
to
7d882ce
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2050051
branch
2 times, most recently
from
7f60d1a
to
f69c34b
Compare
…er-options-type.html This CL adds names to each shared workers in shared-worker-options-type.html. to make the test work correctly. Without this change, 'module' shared workers tests don't actually run. This test would fail without this change when #5258 is implemented: whatwg/html#5258 Bug: 1051779 Change-Id: I7b5ea901b07cfb9f5b73e8948e1e7757ab7c5c34 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050051 Commit-Queue: Eriko Kurimoto <elkurin@google.com> Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#740994}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2050051
branch
from
f69c34b
to
b7a39c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This CL adds names to each shared workers in shared-worker-options-type.html.
to make the test work correctly.
Without this change, 'module' shared workers tests don't actually run.
This test would fail without this change when #5258 is implemented:
whatwg/html#5258
Bug: 1051779
Change-Id: I7b5ea901b07cfb9f5b73e8948e1e7757ab7c5c34
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2050051
Commit-Queue: Eriko Kurimoto <elkurin@google.com>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#740994}