New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Staging next #79801
Merged
Merged
Staging next #79801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supported since 0.5 at least
Removes Python 2 support. https://github.com/libgit2/pygit2/blob/v1.0.3/CHANGELOG.rst
…e hash dir This has several advantages: 1. It takes up less space on disk in-between builds in the nix store. 2. It uses less space in the binary cache for vendor derivation packages. 3. It uses less network traffic downloading from the binary cache. 4. It plays nicely with hashed mirrors like tarballs.nixos.org, which only substitute --flat hashes on single files (not recursive directory hashes). 5. It's consistent with how simple `fetchurl` src derivations work. 6. It provides a stronger abstraction between input src-package and output package, e.g., it's harder to accidentally depend on the src derivation at runtime by referencing something like `${src}/etc/index.html`. Likewise, in the store it's harder to get confused with something that is just there as a build-time dependency vs. a runtime dependency, since the build-time src dependencies are tarred up. Disadvantages are: 1. It takes slightly longer to untar at the start of a build. As currently implemented, this attaches the compacted vendor.tar.gz feature as a rider on `verifyCargoDeps`, since both of them are relatively newly implemented behavior that change the `cargoSha256`. If this PR is accepted, I will push forward the remaining rust packages with a series of treewide PRs to update the `cargoSha256`s.
fetchcargo: use flat tar.gz file for vendored src instead of recursive hash dir
No upstream release yet, but libssh2/libssh2#402 has been accepted by upstream devs. Original advisory: https://blog.semmle.com/libssh2-integer-overflow-CVE-2019-17498/ Re #73662
According to https://endoflife.software/programming-languages/server-side-scripting/ruby ruby 2.4 will go end-of-life in march, where the new release of nixpkgs will be cut. We won't be able to support it for security updates. Remove all references to ruby_2_4 and add ruby_2_7 instead where missing. Mark packages that depend on ruby 2.4 as broken: * chefdk * sonic-pi
libgit2: 0.27.8 -> 0.28.4
It's a little suspicious that the binaries are (apparently) linked statically, but I assume upstream has some reasons (e.g. speed).
FRidh
requested review from
alyssais,
andir,
jonringer,
LnL7,
Mic92 and
zimbatm
as code owners
February 11, 2020 07:05
bhipple
approved these changes
Feb 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)