Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains: update #79873

Merged
merged 2 commits into from Feb 14, 2020
Merged

jetbrains: update #79873

merged 2 commits into from Feb 14, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Feb 11, 2020 •
edited

Motivation for this change

noticed it was out of date

ran update.pl

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
[32 built, 6 copied (1457.0 MiB), 1441.5 MiB DL]
https://github.com/NixOS/nixpkgs/pull/79873
12 package built:
jetbrains.clion jetbrains.datagrip jetbrains.goland jetbrains.idea-community jetbrains.idea-ultimate jetbrains.jdk jetbrains.phpstorm jetbrains.pycharm-community jetbrains.pycharm-professional jetbrains.rider jetbrains.ruby-mine jetbrains.webstorm

@liff
Copy link
Contributor

liff commented Feb 14, 2020

Though I don’t think it’s strictly required, it might be a good idea to update the JetBrains JDK along with new releases. Linux version of IDEA community 2019.3.3 ships with JBR 520.38. You can check the JBR version by running jbr/bin/java -version from the upstream package.

@jonringer
Copy link
Contributor Author

you're right:

$ steam-run jbr/bin/java -version
openjdk version "11.0.5" 2019-10-15
OpenJDK Runtime Environment (build 11.0.5+10-b520.38)
OpenJDK 64-Bit Server VM (build 11.0.5+10-b520.38, mixed mode)

@jonringer
Copy link
Contributor Author

@GrahamcOfBorg build jetbrains.jdk

@jonringer jonringer merged commit 25f6f66 into NixOS:master Feb 14, 2020
@jonringer jonringer deleted the update-jetbrains branch February 26, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonringer @liff