Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cypress: 3.6.1 -> 3.8.3 #79871

Merged
merged 2 commits into from Feb 11, 2020
Merged

Conversation

kalbasit
Copy link
Member

@kalbasit kalbasit commented Feb 11, 2020

Motivation for this change

Cypress 3.8.3 was released 18 days ago.

Note that since then they've released version 4, but that's a major release that requires some effort to migrate to. I think we should create a separate attribute for version 4.

This version also changes where the binary_state.json is located.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from mmahut February 11, 2020 22:54
@kalbasit kalbasit merged commit 2f61814 into NixOS:master Feb 11, 2020
@kalbasit kalbasit deleted the nixpkgs_update-cypress branch February 11, 2020 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant