Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

brscan4: 0.4.4-4 -> 0.4.8-1 #79872

Merged
merged 1 commit into from Mar 4, 2020
Merged

brscan4: 0.4.4-4 -> 0.4.8-1 #79872

merged 1 commit into from Mar 4, 2020

Conversation

danme
Copy link
Contributor

@danme danme commented Feb 11, 2020

Motivation for this change

Support more Brother devices.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jraygauthier
jraygauthier approved these changes Feb 11, 2020
View reviewed changes
Copy link
Member

@jraygauthier jraygauthier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code is fine. Tested the amd64 binaries by cherry-picking on my 19.09 config. Still scans fine.

JeffLabonte
JeffLabonte approved these changes Mar 4, 2020
View reviewed changes
Copy link
Contributor

@JeffLabonte JeffLabonte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/approved-pr-unmerged-opened-3-weeks/6108/1

@danbst danbst merged commit 308d840 into NixOS:master Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jraygauthier jraygauthier jraygauthier approved these changes

@JeffLabonte JeffLabonte JeffLabonte approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@danme @nixos-discourse @jraygauthier @JeffLabonte @danbst