New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azuredatastudio: init at 1.17.1 #80610
Conversation
a6725af
to
d4dffd7
Compare
70ebe32
to
8b36f1c
Compare
I have been wanting to add azure date studio to nixpkgs as well |
463124c
to
c30d5dc
Compare
c30d5dc
to
6cf4bed
Compare
@husseinraoouf thanks for the bump. Applied the requested changes from above, and updated the package to |
@xavierzwirtz Could you also add desktop item so the app icons appear in the applications menu, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Passes nixpkgs-review
build and --help
test.
@timokau could you take a look at this? |
Looks good to me. Thanks @xavierzwirtz for the contribution and @doronbehar for the review :) |
Motivation for this change
Packages azuredatastudio for NixOS.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)