Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuredatastudio: init at 1.17.1 #80610

Merged
merged 1 commit into from May 25, 2020
Merged

Conversation

xavierzwirtz
Copy link
Contributor

Motivation for this change

Packages azuredatastudio for NixOS.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@xavierzwirtz xavierzwirtz force-pushed the azuredatastudio branch 2 times, most recently from 70ebe32 to 8b36f1c Compare February 26, 2020 08:12
@husseinraoouf
Copy link
Contributor

I have been wanting to add azure date studio to nixpkgs as well
I have noticed this pr but it is kind of inactive for a while, so if you are busy I will be happy to continue your work
@xavierzwirtz

@xavierzwirtz xavierzwirtz force-pushed the azuredatastudio branch 2 times, most recently from 463124c to c30d5dc Compare May 18, 2020 19:41
@xavierzwirtz
Copy link
Contributor Author

@husseinraoouf thanks for the bump. Applied the requested changes from above, and updated the package to 1.17.1.

@xavierzwirtz xavierzwirtz changed the title azuredatastudio: init at 1.15.1 azuredatastudio: init at 1.17.1 May 18, 2020
@husseinraoouf
Copy link
Contributor

@xavierzwirtz Could you also add desktop item so the app icons appear in the applications menu,
I think it would be better than opening the app from the terminal

Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nixpkgs-review build and --help test.

@doronbehar
Copy link
Contributor

@timokau could you take a look at this?

@timokau
Copy link
Member

timokau commented May 25, 2020

Looks good to me. Thanks @xavierzwirtz for the contribution and @doronbehar for the review :)

@timokau timokau merged commit 9da092d into NixOS:master May 25, 2020
@xavierzwirtz xavierzwirtz deleted the azuredatastudio branch May 25, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants