Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: cd97c055a09c
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 6d8539c1d8fd
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Feb 20, 2020

  1. perl: Enable threading on darwin 

    Perl on darwin (and any other sane platform) has a pretty good threading
support, enable it.

As it turns out, we were building non-multithreaded perl on all systems,
since glibc was not part of the stdenv anymore:

    nix-repl> pkgs = import <nixpkgs> {}

    nix-repl> pkgs.stdenv ? glibc
    false

meaning that the comments were incorrect. Thus, clear up the confusion
and remove the misleading comments, while enabling multithreading by
default. The builds will fail on unsupported platforms, and in this case
the only place is the bootstrap, where we already force
non-multithreaded perl.

As a consequence of the above, this change will cause the full rebuild
of stdenv on all platforms, including linux.
    @knl @FRidh
    knl authored and FRidh committed Feb 20, 2020
    Copy the full SHA
    6d8539c View commit details
    Browse the repository at this point in the history