Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gildas: 20200101_a -> 20200201_a #80640

Merged
merged 1 commit into from Feb 25, 2020
Merged

gildas: 20200101_a -> 20200201_a #80640

merged 1 commit into from Feb 25, 2020

Conversation

smaret
Copy link
Member

@smaret smaret commented Feb 20, 2020

Motivation for this change

Upgrade gildas to the latest upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@smaret
gildas: 20200101_a -> 20200201_a
7667207 
 - Upgrade gildas to the latest version

 - Remove a patch that has been included upstream

 - Re-enable parallel building (fixed upstream)
@ofborg ofborg bot requested a review from bzizou February 20, 2020 14:53
@veprbl
Copy link
Member

veprbl commented Feb 25, 2020

@GrahamcOfBorg build gildas

@veprbl veprbl merged commit b9ee6cd into NixOS:master Feb 25, 2020
@smaret smaret deleted the gildas-20200201a branch February 25, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bzizou bzizou Awaiting requested review from bzizou

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smaret @veprbl