Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ucx: init at 1.7.0 #80641

Merged
merged 1 commit into from Feb 20, 2020
Merged

ucx: init at 1.7.0 #80641

merged 1 commit into from Feb 20, 2020

Conversation

ikervagyok
Copy link
Contributor

Motivation for this change

split from #79771

Things done

took https://github.com/markuskowa/NixOS-QChem/blob/ucx/ucx/default.nix and went through it. the differences are:

  1. the configure option --with-verbs seems to need the path of rdma-core passed to it (suggested by the configure log).
  2. removal of the local optimization
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants