Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel-remote: 2020-01-29 -> 1.0.0 #80527

Merged
merged 1 commit into from Feb 20, 2020
Merged

bazel-remote: 2020-01-29 -> 1.0.0 #80527

merged 1 commit into from Feb 20, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Feb 19, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from uri-canva February 19, 2020 11:57
@uri-canva
Copy link
Contributor

The change looks good, but it doesn't build on darwin because bazel has been failing for a while now: https://hydra.nixos.org/job/nixpkgs/trunk/bazel.x86_64-darwin

@marsam marsam merged commit 82a6834 into NixOS:master Feb 20, 2020
@marsam marsam deleted the update-bazel-remote branch February 20, 2020 01:03
@uri-canva
Copy link
Contributor

I think you forgot to run the builds before merging.

@uri-canva
Copy link
Contributor

I don't have permissions to trigger them so I can't do it but you comment @GrahamcOfBorg build bazel-remote like here: #68471 (comment)

@marsam
Copy link
Contributor Author

marsam commented Feb 20, 2020

if the commit contains the attribute i.e. bazel-remote: ..., ofborg builds them automatically https://github.com/NixOS/nixpkgs/pull/80527/checks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uri-canva uri-canva uri-canva approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marsam @uri-canva