niv: reduce the closure size when using the executable #80644
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As the most intended use for the tool is in the CLI, we should only get the executable with a small closure size.
|
@GrahamcOfBorg build niv |
nmattia
approved these changes
Feb 20, 2020
|
I don't see any improvement when following this PR. The size is the same. |
|
@knl could it be that you were downloading all build dependencies, so that the executable could be built by nix on your machine? It doesn't appear to be present in cache.nixos.org. Note: I've updated the installation instructions for using niv's cache. |
|
I can testify that these are the dependencies I had downloaded when using the command at the installation instructions: Most of which don't seem like build dependencies to me.. |
|
Mh, yeah. They're needed to build |
|
So this is an upstream issue for Niv and not for Nixpkgs? Shall we close
thise then?
|
|
The issue brought up by @doronbehar is definitely upstream, I'll have to fix it there. Re. this particular issue, I can't reproduce. I think we can close when @knl confirms #80644 (comment) |
|
FTR @doronbehar the niv issue is tracked in nmattia/niv#204 and should be fixed in nmattia/niv#205 |
knl
changed the title
|
@doronbehar - @nmattia's fix in nmattia/niv#205 indeed makes the downloaded size smaller. Closing this PR as it should have started as a Draft. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
As the most intended use for the tool is in the CLI, we should only get
the executable with a small closure size.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)