Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 47ab49ac44bb
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 7789299ff9a0
Choose a head ref
  • 3 commits
  • 3 files changed
  • 2 contributors

Commits on Feb 19, 2020

  1. maintainers: add Luflosi

    @Luflosi
    Luflosi committed Feb 19, 2020
    Copy the full SHA
    ff80331 View commit details
    Browse the repository at this point in the history

  2. kitty: better fix for build error 

    Without the `no-werror.patch`, the compilation would fail with the following warning:
```
clang-7: error: argument unused during compilation: '-fno-strict-overflow' [-Werror,-Wunused-command-line-argument]
```
To fix this, the compiler command line options `-pedantic-errors` and `-Werror` were patched out of the build script so that the warning would not become an error and stop the build. This is not ideal as this piece of code is changed fairly frequently, which requires fixing the patch. In the next kitty version the patch would need to be fixed again.
A better alternative is to just not pass `-fno-strict-overflow` to the compiler. This is done by disabling the `strictoverflow` hardening feature.
    @Luflosi
    Luflosi committed Feb 19, 2020
    Copy the full SHA
    2a15e3b View commit details
    Browse the repository at this point in the history

  3. Merge pull request #80546 from Luflosi/kitty-disable-strictoverflow 

    kitty: better fix for build error
    @rnhmjoj
    rnhmjoj committed Feb 19, 2020
    Copy the full SHA
    7789299 View commit details
    Browse the repository at this point in the history