Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.mask-rcnn: init at 2.1 #80520

Merged
merged 1 commit into from Mar 19, 2020
Merged

pythonPackages.mask-rcnn: init at 2.1 #80520

merged 1 commit into from Mar 19, 2020

Conversation

Rakesh4G
Copy link
Contributor

@Rakesh4G Rakesh4G commented Feb 19, 2020 •
edited

Motivation for this change

pythonPackages.mask-rcnn: init at 2.1

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    @CMCDragonkai

@Rakesh4G
Copy link
Contributor Author

Rakesh4G commented Feb 19, 2020 •
edited

currently dependency tensor-flow is failing.
ERROR: /build/output/external/grpc/BUILD:507:1: C++ compilation of rule '@grpc//:gpr_base' failed (Exit 1)
seems related to :
tensorflow/tensorflow#34291

@jonringer
Copy link
Contributor

unfortunately, I don't see tensorflow getting fixed anytime soon

@Rakesh4G Rakesh4G force-pushed the mask-rcnn branch 2 times, most recently from 679257c to a52564d Compare February 25, 2020 05:27
@CMCDragonkai
Copy link
Member

I suspect that mask-rcnn can be used with cuda or without cuda. This means that we should have a cuda version as well. This is similar to the other packages that have WithCuda as a suffix. However because the name of this is mask-rcnn then I guess it's more like mask-rcnn-with-cuda and mask-rcnn.

Also this should be kept as a library, not application.

Then mask-rcnn-with-cuda will have tensorflow substituted with tensorflowWithCuda.

The only other package that has WithCuda that isn't the tensorflow/theano/pytorch is colmap where there's colmapWithCuda. It could make sense that this only applies to applications, and libraries should be as the basic version.

@Rakesh4G
Copy link
Contributor Author

Rakesh4G commented Mar 6, 2020

Hi @jonringer ,

This is now fixed.
The broken tensorflow dependency has been fixed.
#81633

@CMCDragonkai

@FRidh
Copy link
Member

FRidh commented Mar 6, 2020

We typically avoid top-level variations of a package when options are already present.

jonringer
jonringer reviewed Mar 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise diff LGTM,

still waiting on tensorflow to not be broken to ensure the package works

pkgs/development/python-modules/mask-rcnn/default.nix Outdated Show resolved Hide resolved
jonringer
jonringer approved these changes Mar 19, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
commit LGTM

[4 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80520
1 package marked as broken and skipped:
python38Packages.mask-rcnn

1 package built:
python37Packages.mask-rcnn

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python37Packages.mask-rcnn

@jonringer jonringer merged commit e346367 into NixOS:master Mar 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Rakesh4G @jonringer @CMCDragonkai @FRidh