Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.aiohttp: remove pytest-timeout check dependency #80632

Merged
merged 1 commit into from Feb 21, 2020
Merged

pythonPackages.aiohttp: remove pytest-timeout check dependency #80632

merged 1 commit into from Feb 21, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Feb 20, 2020 •
edited

Motivation for this change

pytest-timeout is kinda flaky, and as it turns out, aiohttp doesn't use it.

This was initially done for ZHF, but, it kinda doesn't matter for that purpose? The build is currently passing on Hydra, because the flaky test is currently passing, and it would rather make sense to fix pytest-timeout for stable branches to minimize the changes.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg build python37Packages.aiohttp

@ofborg ofborg bot requested a review from dotlambda February 20, 2020 13:54
jonringer
jonringer reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commit message should be:

pythonPackages.aiohttp: remove pytest-timeout check dependency

@KamilaBorowska KamilaBorowska force-pushed the aiohttp-remove-pytest-timeout-dependency branch from 53985cc to 3eba456 Compare February 20, 2020 18:26
@worldofpeace worldofpeace changed the title python/aiohttp: Remove pytest-timeout dependency pythonPackages.aiohttp: remove pytest-timeout check dependency Feb 20, 2020
@jonringer
Copy link
Contributor

@GrahamcOfBorg build pythonPackages.aiohttp
@GrahamcOfBorg build python3Packages.aiohttp
@GrahamcOfBorg build python38Packages.aiohttp

@jonringer jonringer merged commit 621c423 into NixOS:master Feb 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@dotlambda dotlambda Awaiting requested review from dotlambda

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KamilaBorowska @jonringer