Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialization of EulerSolver #2474

Merged
merged 3 commits into from
Feb 20, 2020
Merged

Conversation

pleroy
Copy link
Member

@pleroy pleroy commented Feb 19, 2020

No description provided.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@@ -104,9 +111,11 @@ class EulerSolver {

// Construction parameters.
R3Element<MomentOfInertia> const moments_of_inertia_;
Bivector<AngularMomentum, InertialFrame> const initial_angular_momentum_;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should never be used for any purpose other than serialization (see // Do not use initial_angular_momentum after this point. in the body).
Rename it to serializable_initial_angular_momentum_ (or perhaps serialized), and change preferred_initial_angular_momentum_ back to initial_angular_momentum_.

Sorry, something went wrong.

@eggrobin eggrobin added the LGTM label Feb 20, 2020
@pleroy pleroy merged commit 764cf8e into mockingbirdnest:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants