Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

plan9port: fix linker flags for macosx #80603

Merged
merged 2 commits into from Feb 22, 2020
Merged

plan9port: fix linker flags for macosx #80603

merged 2 commits into from Feb 22, 2020

Conversation

eraserhd
Copy link
Contributor

Motivation for this change

PR #77632 made Mac builds more reproducible by adding some linker
flags to $NIX_LDFLAGS; however, plan9port uses the C compiler
front end as a linker, requiring these new options to be wrapped
with -Wl.

This fixes the Mac build of plan9port.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @LnL7 @AndersonTorres @bbarker @ftrvxmtrx @KoviRobi

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Feb 20, 2020
@marsam marsam mentioned this pull request Feb 20, 2020
Merged
10 tasks
@KoviRobi
Copy link
Contributor

LGTM, I don't have a Mac but it seems to work on Linux without any changes.

@AndersonTorres
Copy link
Member

I have no Darwin machine to test it :/

@LnL7 LnL7 merged commit fd4df0b into NixOS:master Feb 22, 2020
@LnL7 LnL7 mentioned this pull request Feb 23, 2020
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eraserhd @KoviRobi @AndersonTorres @LnL7