Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tor: fix build #80512

Merged
merged 1 commit into from Feb 19, 2020
Merged

tor: fix build #80512

merged 1 commit into from Feb 19, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Feb 19, 2020 •
edited

Monotonic timer test expects sleep(200ms) to take at most 1s. On loaded systems like hydra, it's possible for such a test to take longer than 1 second.

Tests expecting sleep(200ms) to take at least 175ms weren't removed, because load shouldn't cause sleep to be shorter.

Motivation for this change

ZHF: #80379

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
tor: fix build
58af317 
Monotonic timer test expects sleep(200ms) to take at most 1s. On
loaded systems like hydra, it's possible for such a test to take
longer than 1 second.

Tests expecting sleep(200ms) to take at least 175ms weren't removed,
because load shouldn't cause sleep to be shorter.
@KamilaBorowska
Copy link
Member Author

KamilaBorowska commented Feb 19, 2020 •
edited

@GrahamcOfBorg test tor

@Ma27 Ma27 added the 9.needs: port to stable A PR needs a backport to the stable release. label Feb 19, 2020
@Ma27 Ma27 merged commit 5ea1930 into NixOS:master Feb 19, 2020
@Ma27
Copy link
Member

Ma27 commented Feb 19, 2020

Thanks! Backported as 6121d36.

@Ma27 Ma27 added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Feb 19, 2020
@KamilaBorowska KamilaBorowska mentioned this pull request Feb 20, 2020
Closed
@peterhoeg peterhoeg mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@oxij oxij Awaiting requested review from oxij

@joachifm joachifm Awaiting requested review from joachifm

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@Phreedom Phreedom Awaiting requested review from Phreedom

Assignees
No one assigned
Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KamilaBorowska @Ma27