Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/zfs: enable encryption test for stable zfs #80559

Merged
merged 1 commit into from Aug 16, 2020
Merged

nixos/zfs: enable encryption test for stable zfs #80559

merged 1 commit into from Aug 16, 2020

Conversation

Frostman
Copy link
Member

@Frostman Frostman commented Feb 19, 2020 •
edited

Motivation for this change

Stable ZFS is already 0.8.x, so, we should run encryption test for it as well. Keeping extraTests for the next time there will be an unstable version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@Frostman
Copy link
Member Author

@GrahamcOfBorg test zfs

@Frostman Frostman requested a review from Mic92 February 19, 2020 20:02
@alyssais alyssais merged commit da4e029 into NixOS:master Aug 16, 2020
@Frostman Frostman deleted the zfs-enable-enc-test branch August 21, 2020 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Frostman @alyssais