Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lbzip2: 2.5 -> 2.5+git20180127 #80560

Closed
wants to merge 1 commit into from
Closed

lbzip2: 2.5 -> 2.5+git20180127 #80560

wants to merge 1 commit into from

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Feb 19, 2020

The build fails with newer glibc due to vendored gnulib.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @abbradar

@mmilata
lbzip2: 2.5 -> 2.5+git20180127
f3ad0d0 
The gnulib-tool invocation in build-aux/autogen.sh needs to be
substituteInPlace'd because it tries to copy files from /nix/store
including the permissions and then tries to modify them which fails due
to lacking write bit.
@ofborg ofborg bot requested a review from abbradar February 19, 2020 19:50
@mmilata mmilata mentioned this pull request Feb 24, 2020
Merged
10 tasks
@mmilata mmilata closed this Feb 27, 2020
bennofs added a commit that referenced this pull request Aug 19, 2020
@bennofs
lbzip2: fix build
fc96673 
This is backport of #80560 (since we don't have updated gnulib in 20.03)
and #80906.

Based on 07cf036
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@mmilata