Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iosevka: disable update check in build #80618

Merged
merged 1 commit into from Feb 24, 2020
Merged

iosevka: disable update check in build #80618

merged 1 commit into from Feb 24, 2020

Conversation

rileyinman
Copy link
Contributor

Motivation for this change

The npm box saying the update check failed was annoying me, and getting rid of it seemed appropriate seeing as we now redirect the main build to /dev/null as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

babariviere
babariviere approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@babariviere babariviere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great 👍

@ttuegel ttuegel merged commit 87d1c38 into NixOS:master Feb 24, 2020
@rileyinman rileyinman deleted the iosevka branch February 25, 2020 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

@babariviere babariviere babariviere approved these changes

@jfrankenau jfrankenau Awaiting requested review from jfrankenau

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rileyinman @ttuegel @babariviere