Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

talloc: 2.1.14 -> 2.1.16, build with python3 #80537

Merged
merged 1 commit into from Feb 26, 2020
Merged

Conversation

sorki
Copy link
Member

@sorki sorki commented Feb 19, 2020

Motivation for this change

Update so it builds with py3 and doesn't pull py2 into iso_minimal.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Feb 19, 2020

@matthewbauer added the buildPackages version in 9c8fd41

@FRidh FRidh added this to the 20.03 milestone Feb 19, 2020
@FRidh FRidh added this to Needs review in Python 2 deprecation Feb 19, 2020
@sorki
Copy link
Member Author

sorki commented Feb 19, 2020

@matthewbauer added the buildPackages version in 9c8fd41

Addressed

@FRidh FRidh merged commit d617e54 into NixOS:master Feb 26, 2020
Python 2 deprecation automation moved this from Needs review to Done Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants