Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codebraid: init at 0.5.0-unstable-2019-12-11 #80536

Merged
merged 2 commits into from Feb 23, 2020
Merged

Codebraid: init at 0.5.0-unstable-2019-12-11 #80536

merged 2 commits into from Feb 23, 2020

Conversation

Synthetica9
Copy link
Member

Motivation for this change

As to why I'm specifically using an unstable version: after 0.4.0 a few nice new features were introduced, like:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Synthetica9 Synthetica9 changed the title Codebraid init Codebraid: init at 0.5.0-unstable-2019-12-11 Feb 19, 2020
jonringer
jonringer reviewed Feb 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer unittests, but I'll compromise for the suggestions.

pkgs/development/python-modules/bespon/default.nix Outdated Show resolved Hide resolved
pkgs/tools/misc/codebraid/default.nix Outdated Show resolved Hide resolved
@Synthetica9
Copy link
Member Author

@jonringer Request granted :)

@jonringer
Copy link
Contributor

please squash the fix up commits into the related commits, git rebase -i makes this easy

Synthetica9 and others added 2 commits February 23, 2020 11:47
@Synthetica9 @jonringer
pythonPackages.bespon: init at 0.3.0
5acbf31 
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@Synthetica9 @jonringer
codebraid: init at 0.5.0-unstable-2019-12-11
0e00d55 
Co-Authored-By: Jon <jonringer@users.noreply.github.com>
@Synthetica9
Copy link
Member Author

@jonringer Done

jonringer
jonringer approved these changes Feb 23, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, would still like more tests

[7 built, 0.0 MiB DL]
https://github.com/NixOS/nixpkgs/pull/80536
4 package built:
codebraid python27Packages.bespon python37Packages.bespon python38Packages.bespon

@jonringer
Copy link
Contributor

@GrahamcOfBorg build codebraid python27Packages.bespon python37Packages.bespon python38Packages.bespon

@jonringer jonringer merged commit 7062fa3 into NixOS:master Feb 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Synthetica9 @jonringer