Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.can: remove pytest-timeout check input #80636

Merged
merged 1 commit into from Feb 20, 2020
Merged

pythonPackages.can: remove pytest-timeout check input #80636

merged 1 commit into from Feb 20, 2020

Conversation

KamilaBorowska
Copy link
Member

@KamilaBorowska KamilaBorowska commented Feb 20, 2020 •
edited

Motivation for this change

ZHF: #80379

pytest-timeout can cause tests to be flaky. It's not necessary to patch the code, as pytest ignores unrecognized marks with an ignorable warning.

This can be backported in order to avoid possible flakiness in the future.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
pythonPackages.can: remove pytest-timeout check input
ec06d0b 
pytest-timeout can cause tests to be flaky. It's not
necessary to patch the code, as pytest ignores unrecognized
marks with an ignorable warning.
@KamilaBorowska
Copy link
Member Author

@GrahamcOfBorg build python27Packages.can python37Packages.can python38Packages.can

@ofborg ofborg bot requested a review from sorki February 20, 2020 14:31
sorki
sorki approved these changes Feb 20, 2020
View reviewed changes
Copy link
Member

@sorki sorki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jonringer
jonringer approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

https://github.com/NixOS/nixpkgs/pull/80636
1 package failed to build:
python38Packages.canopen

5 package built:
python27Packages.can python27Packages.canopen python37Packages.can python37Packages.canopen python38Packages.can

@jonringer
Copy link
Contributor

failure is broken on master and unrelated to PR

@jonringer jonringer merged commit 8dd592e into NixOS:master Feb 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorki sorki sorki approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KamilaBorowska @jonringer @sorki