Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bazel: fix build on darwin #80635

Merged
merged 1 commit into from Feb 22, 2020
Merged

bazel: fix build on darwin #80635

merged 1 commit into from Feb 22, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Feb 20, 2020

Motivation for this change

Fixes: #80440

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This solution was shamelessly stolen from #80603

@ofborg ofborg bot added the 6.topic: darwin Running or building packages on Darwin label Feb 20, 2020
@ofborg ofborg bot requested a review from mboes February 20, 2020 14:24
@uri-canva
Copy link
Contributor

Tested on macOS, works.

@LnL7 LnL7 merged commit e4af779 into NixOS:master Feb 22, 2020
@worldofpeace
Copy link
Contributor

@marsam Was this an issue on 20.03?

@LnL7
Copy link
Member

LnL7 commented Feb 23, 2020

@worldofpeace Yeah, both this and plan9 should be backported. Should I make a pr for those or are updates still being synced?

@worldofpeace
Copy link
Contributor

@worldofpeace Yeah, both this and plan9 should be backported. Should I make a pr for those or are updates still being synced?

I believe a PR should be good 👍

@LnL7 LnL7 mentioned this pull request Feb 23, 2020
Merged
10 tasks
@uri-canva uri-canva mentioned this pull request Feb 27, 2020
Merged
10 tasks
@marsam marsam deleted the fix-bazel-darwin branch May 31, 2023 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@Profpatsch Profpatsch Awaiting requested review from Profpatsch Profpatsch is a code owner

@mboes mboes Awaiting requested review from mboes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 11-100 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bazel broken on darwin
4 participants
@marsam @uri-canva @worldofpeace @LnL7